Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jazzy docs #190

Closed
wants to merge 62 commits into from
Closed

Jazzy docs #190

wants to merge 62 commits into from

Conversation

xtopolis
Copy link

@xtopolis xtopolis commented Oct 21, 2019

Before you make a Pull Request, read the important guidelines:

Issue Link 🔗

  • Is this a bug fix or a feature? **Feature**
  • Does it break any existing functionality? **Unit Tests still pass**

Goals of this PR 🎉

How Has This Been Tested 🔍

Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.

  • N/A

Test Configuration 👾

  • Xcode version: 10.3

Things to check on 🎯

  • My Pull Request code follows the coding standards and styles of the project
  • [N/A] I have worked on unit tests and reviewed my code to the best of my ability
  • I have used comments to make other coders understand my code better
  • My changes are good to go without any warnings
  • [N/A] I have added unit tests both for the happy and sad path
  • All of my unit tests pass successfully before pushing the PR
  • I have made sure all dependent downstream changes impacted by my PR are working

@xtopolis
Copy link
Author

@croossin Need to do a little review, but it's at 100% documentation. A lot of it is redundant property name, or self explanatory property comments. Anything else you'd like done?

@xtopolis
Copy link
Author

Ready for any final comments and whether or not I should add in build step or leave it to you.

@croossin
Copy link
Contributor

Would be awesome to have as a build step @xtopolis - but how much of a lift is that?

@croossin
Copy link
Contributor

croossin commented Nov 5, 2019

@xtopolis Is it hard to get this in the build pipeline?

@xtopolis
Copy link
Author

xtopolis commented Nov 6, 2019

I'll be able to look into it by end of week/this weekend, sorry for the delay.

@xtopolis
Copy link
Author

@croossin Merge away if ready

@xtopolis xtopolis closed this by deleting the head repository Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants