Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log config can be configured #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blekinge
Copy link

Simple change that allows you to specify a logconfig file as a command line param to umbra, rather than having the log config hardcoded

args = arg_parser.parse_args(args=sys.argv[1:])

logging.basicConfig(stream=sys.stdout, level=args.log_level,
if (args.log_config_file is not None):
print(os.path.abspath(args.log_config_file))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this would be more friendly:
print("configuring logging from %s" % os.path.abspath(args.log_config_file))

@nlevitt
Copy link
Contributor

nlevitt commented May 16, 2019

Is logging.conf meant to be just an example? Maybe call it example-logging.conf then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants