prometheus metrics for brozzler, plus yt-dlp #287
Closed
+127
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galgeek
force-pushed
the
new_metrics
branch
from
0748675
to
2d7efba
Compare
galgeek
force-pushed
the
new_metrics
branch
2 times, most recently
from
b3e08b9
to
362b6fd
Compare
galgeek
force-pushed
the
new_metrics
branch
2 times, most recently
from
776840c
to
d83262f
Compare
galgeek
force-pushed
the
new_metrics
branch
from
d83262f
to
6609645
Compare
wilsoniya
reviewed
Sep 17, 2024
| default=None, | ||
| help="Prometheus scrape target registry URL", | ||
| ) | ||
| arg_parser.add_argument( |
There was a problem hiding this comment.
Consider adding:
choices=["qa", "prod"],
|
Note: I'm focusing now on updating #289, which replaces this, and plan to close this PR soon. |
|
closing in favor of #289 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.