Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper YouTube archiving via YT-DLP #126

Merged
merged 15 commits into from
Sep 12, 2024
Merged

Add proper YouTube archiving via YT-DLP #126

merged 15 commits into from
Sep 12, 2024

Conversation

CorentinB
Copy link
Collaborator

No description provided.

@CorentinB CorentinB added enhancement New feature or request internal-only This PR/Issue is reserved for the IA team P3 normal priority labels Aug 12, 2024
@CorentinB CorentinB self-assigned this Aug 12, 2024
equals215
equals215 requested changes Aug 12, 2024
View reviewed changes
Copy link
Member

@equals215 equals215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job, it doesn't even feel hacky as you said it was

cmd/get.go Show resolved Hide resolved
internal/pkg/crawl/crawl.go Show resolved Hide resolved
internal/pkg/crawl/dependencies/ytdlp/model.go Outdated Show resolved Hide resolved
internal/pkg/crawl/dependencies/ytdlp/parse.go Outdated Show resolved Hide resolved
internal/pkg/crawl/sitespecific/youtube/youtube.go Show resolved Hide resolved
equals215
equals215 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@equals215 equals215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CorentinB CorentinB merged commit cfa2980 into main Sep 12, 2024
1 check failed
@CorentinB CorentinB deleted the ytdlp branch September 28, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@equals215 equals215 equals215 approved these changes

@NGTmeaty NGTmeaty Awaiting requested review from NGTmeaty

Assignees

@CorentinB CorentinB

Labels
enhancement New feature or request internal-only This PR/Issue is reserved for the IA team P3 normal priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CorentinB @equals215