Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch caffeine caches to use expireAfterWrite instead of expireAfterAccess (which doesn't expire under constant load) #606

Merged
merged 4 commits into from
Feb 27, 2020

Conversation

nhartner
Copy link
Collaborator

fix /accounts REST api to handle accountIds with "."

nhartner and others added 3 commits February 26, 2020 17:01
…Access (which doesn't expire under constant load)

fix /accounts REST api to handle accountIds with "."

Signed-off-by: nhartner <[email protected]>
@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@b74a2dc). Click here to learn what that means.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #606   +/-   ##
=========================================
  Coverage          ?   65.37%           
  Complexity        ?     1105           
=========================================
  Files             ?      289           
  Lines             ?     5623           
  Branches          ?      218           
=========================================
  Hits              ?     3676           
  Misses            ?     1850           
  Partials          ?       97
Impacted Files Coverage Δ Complexity Δ
...persistence/config/ConnectorPersistenceConfig.java 100% <ø> (ø) 1 <0> (?)
...ence/config/EncryptedDatasourcePasswordConfig.java 90% <90%> (ø) 5 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b74a2dc...e940225. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #606 into master will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #606      +/-   ##
============================================
+ Coverage     65.37%   65.41%   +0.03%     
- Complexity     1105     1110       +5     
============================================
  Files           289      289              
  Lines          5623     5655      +32     
  Branches        218      221       +3     
============================================
+ Hits           3676     3699      +23     
- Misses         1850     1857       +7     
- Partials         97       99       +2
Impacted Files Coverage Δ Complexity Δ
...nnector/packetswitch/DefaultILPv4PacketSwitch.java 91.66% <ø> (ø) 4 <0> (ø) ⬇️
...er/connector/links/DefaultNextHopPacketMapper.java 81.18% <ø> (ø) 11 <0> (ø) ⬇️
...a/org/interledger/connector/fx/JavaMoneyUtils.java 100% <ø> (ø) 3 <0> (ø) ⬇️
...ector/packetswitch/filters/ExpiryPacketFilter.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...onnector/links/filters/DefaultLinkFilterChain.java 65.78% <59.37%> (-16.03%) 6 <2> (+3)
...switch/filters/DefaultPacketSwitchFilterChain.java 87.5% <82.85%> (-2.25%) 7 <4> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e940225...fd5f2d2. Read the comment docs.

@nhartner nhartner merged commit 7c189bb into master Feb 27, 2020
@nhartner nhartner deleted the nh/fix-expireAfterWrite branch February 27, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants