Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bg/tabEvents): don't clear sessions on iframe navigation #831

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Jan 13, 2025

Context

Closes #819
Part of #610

Changes proposed in this pull request

Fix issue and add E2E tests to validate cause of #819.

@github-actions github-actions bot added area: popup Improvements or additions to extension popup area: tests Improvements or additions to tests area: pages Changes to any of extension's pages labels Jan 13, 2025
Copy link
Contributor

github-actions bot commented Jan 13, 2025

Extension builds preview

Name Link
Latest commit 0d50cd2
Latest job logs Run #12748187833
BadgeDownload
BadgeDownload

sidvishnoi

This comment was marked as off-topic.

Copy link
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

@sidvishnoi sidvishnoi changed the title test(e2e): add iframe monetization & navigation tests test(e2e): add iframe monetization tests Jan 13, 2025
@sidvishnoi sidvishnoi changed the title test(e2e): add iframe monetization tests test(e2e/special): add iframe navigation edge-case tests Jan 13, 2025
@sidvishnoi sidvishnoi marked this pull request as ready for review January 13, 2025 12:46
@sidvishnoi
Copy link
Member Author

Will add iframe monetization tests as follow-up, once the playground can support it better (WICG/webmonetization#491)

Copy link
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

@github-actions github-actions bot added the area: background Improvements or additions to extension background script label Jan 13, 2025
Copy link
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

Copy link
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

@sidvishnoi sidvishnoi changed the title test(e2e/special): add iframe navigation edge-case tests fix(bg/tabEvents): don't clear sessions on iframe navigation Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: background Improvements or additions to extension background script area: pages Changes to any of extension's pages area: popup Improvements or additions to extension popup area: tests Improvements or additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site becomes not monetized on clicking 1password notification
1 participant