Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): test reconnect wallet with automatic key addition #830

Merged
merged 10 commits into from
Jan 15, 2025
Merged

test(e2e): test reconnect wallet with automatic key addition #830

merged 10 commits into from
Jan 15, 2025

Conversation

DarianM
Copy link
Member

@DarianM DarianM commented Jan 13, 2025 •
edited by sidvishnoi
Loading

Context

Part of #821
Part of #610

@github-actions github-actions bot added the area: tests Improvements or additions to tests label Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025 •
edited
Loading

Extension builds preview

Name Link
Latest commit c660038
Latest job logs Run #12785865502
BadgeDownload
BadgeDownload

@DarianM DarianM requested a review from sidvishnoi January 13, 2025 10:19
sidvishnoi
sidvishnoi reviewed Jan 13, 2025
View reviewed changes
tests/e2e/reconnect.spec.ts Outdated Show resolved Hide resolved
tests/e2e/reconnect.spec.ts Outdated Show resolved Hide resolved
tests/e2e/reconnect.spec.ts Outdated Show resolved Hide resolved
tests/e2e/reconnect.spec.ts Outdated Show resolved Hide resolved
tests/e2e/reconnect.spec.ts Outdated Show resolved Hide resolved
sidvishnoi
sidvishnoi reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

@DarianM DarianM marked this pull request as ready for review January 14, 2025 00:21
DarianM
DarianM commented Jan 14, 2025
View reviewed changes
Copy link
Member Author

@DarianM DarianM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

sidvishnoi
sidvishnoi reviewed Jan 14, 2025
View reviewed changes
tests/e2e/reconnectAutoKeyTestWallet.spec.ts Outdated Show resolved Hide resolved
tests/e2e/reconnectAutoKeyTestWallet.spec.ts Outdated Show resolved Hide resolved
tests/e2e/reconnectAutoKeyTestWallet.spec.ts Outdated Show resolved Hide resolved
tests/e2e/reconnectAutoKeyTestWallet.spec.ts Outdated Show resolved Hide resolved
tests/e2e/reconnectAutoKeyTestWallet.spec.ts Outdated Show resolved Hide resolved
tests/e2e/reconnectAutoKeyTestWallet.spec.ts Outdated Show resolved Hide resolved
tests/e2e/reconnectAutoKeyTestWallet.spec.ts Outdated Show resolved Hide resolved
DarianM
DarianM commented Jan 14, 2025
View reviewed changes
Copy link
Member Author

@DarianM DarianM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

sidvishnoi
sidvishnoi reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

@github-actions github-actions bot added the area: ci Improvements or additions to repository workflows label Jan 15, 2025
sidvishnoi
sidvishnoi reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

sidvishnoi
sidvishnoi reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

@sidvishnoi sidvishnoi force-pushed the e2e-test-reconnect-reset-error-state branch from cb3bf97 to 72645e5 Compare January 15, 2025 09:52
sidvishnoi
sidvishnoi reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

@sidvishnoi sidvishnoi force-pushed the e2e-test-reconnect-reset-error-state branch from 72645e5 to eec4391 Compare January 15, 2025 09:53
sidvishnoi
sidvishnoi reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

sidvishnoi
sidvishnoi reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

@sidvishnoi sidvishnoi merged commit bb3e0a7 into main Jan 15, 2025
10 checks passed
@sidvishnoi sidvishnoi deleted the e2e-test-reconnect-reset-error-state branch January 15, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidvishnoi sidvishnoi sidvishnoi approved these changes

Assignees
No one assigned
Labels
area: ci Improvements or additions to repository workflows area: tests Improvements or additions to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DarianM @sidvishnoi