Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): test monetization event, add custom spy matchers #816

Merged
merged 6 commits into from
Jan 9, 2025
Merged

test(e2e): test monetization event, add custom spy matchers #816

merged 6 commits into from
Jan 9, 2025

Conversation

sidvishnoi
Copy link
Member

Context

Part of #610
Extracted some bits from #815

Changes proposed in this pull request

  • Spy on monetization event with tinyspy
  • Add custom matchers: toHaveBeenCalledTimes, toHaveBeenLastCalledWithMatching

@sidvishnoi sidvishnoi requested a review from DarianM January 9, 2025 12:04
@github-actions github-actions bot added the area: tests Improvements or additions to tests label Jan 9, 2025
sidvishnoi
sidvishnoi commented Jan 9, 2025
View reviewed changes
Copy link
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

@sidvishnoi sidvishnoi changed the title test(e2e): test on monetization event, add custom spy matchers test(e2e): test monetization event, add custom spy matchers Jan 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025 •
edited
Loading

Extension builds preview

Name Link
Latest commit dfb474d
Latest job logs Run #12690080635
BadgeDownload
BadgeDownload

sidvishnoi
sidvishnoi commented Jan 9, 2025
View reviewed changes
tests/e2e/fixtures/base.ts Outdated Show resolved Hide resolved
sidvishnoi
sidvishnoi commented Jan 9, 2025
View reviewed changes
Copy link
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

@sidvishnoi sidvishnoi merged commit b056e23 into main Jan 9, 2025
9 checks passed
@sidvishnoi sidvishnoi deleted the e2e-monetizationCallback branch January 9, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarianM DarianM DarianM approved these changes

Assignees
No one assigned
Labels
area: tests Improvements or additions to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidvishnoi @DarianM