Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(background): remove @interledger/openapi from bundle #811

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Jan 7, 2025

Context

Remove @interledger/openapi from bundle as we don't make use of validations.

Changes proposed in this pull request

-   dist/chrome/background/background.js                     766.5kb
+   dist/chrome/background/background.js                     593.0kb

@github-actions github-actions bot added the area: scripts Improvements or additions to custom scripts label Jan 7, 2025
Copy link
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Extension builds preview

Name Link
Latest commit 99ba511
Latest job logs Run #12676473177
BadgeDownload
BadgeDownload

@sidvishnoi sidvishnoi changed the title chore(esbuild): remove @interledger/openapi from bundle perf(esbuild): remove @interledger/openapi from bundle Jan 7, 2025
@sidvishnoi sidvishnoi changed the title perf(esbuild): remove @interledger/openapi from bundle perf(background): remove @interledger/openapi from bundle Jan 7, 2025
@sidvishnoi sidvishnoi merged commit 0413c96 into main Jan 9, 2025
9 checks passed
@sidvishnoi sidvishnoi deleted the bundle-remove-interledger-openapi branch January 9, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: scripts Improvements or additions to custom scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants