Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support modifying budget #675

Merged
merged 6 commits into from
Oct 24, 2024
Merged

feat: support modifying budget #675

merged 6 commits into from
Oct 24, 2024

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Oct 16, 2024 •
edited
Loading

Context

Closes #674

Changes proposed in this pull request

  • Add UPDATE_BUDGET handler
  • Add submit button on budget screen, which is enabled only if amount/recurring is changed from existing state.
  • Could not use addFunds logic as:
    • we need to revoke all existing grants, not just the ones of same type like addFunds does
    • we also need to clear other grant from storage
    • different intent (for redirect screen)

@github-actions github-actions bot added area: background Improvements or additions to extension background script area: popup Improvements or additions to extension popup labels Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited
Loading

Extension builds preview

Name Link
Latest commit f4ca6ad
Latest job logs Run #11497469928
BadgeDownload
BadgeDownload

@sidvishnoi sidvishnoi marked this pull request as ready for review October 22, 2024 12:58
@sidvishnoi sidvishnoi changed the title feat: support modifying budget [WIP] feat: support modifying budget Oct 22, 2024
@RabebOthmani
Copy link
Collaborator

The change to my budget was never reflected on the wallet but then I made a OTP and I could see it

@sidvishnoi
Copy link
Member Author

Discussed above, the new budget gets reflected in grants page, not on transactions. So, all good.

@sidvishnoi sidvishnoi merged commit 721f0ab into main Oct 24, 2024
8 checks passed
@sidvishnoi sidvishnoi deleted the budget-edit branch October 24, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raducristianpopa raducristianpopa Awaiting requested review from raducristianpopa

@lengyel-arpad85 lengyel-arpad85 Awaiting requested review from lengyel-arpad85

Assignees
No one assigned
Labels
area: background Improvements or additions to extension background script area: popup Improvements or additions to extension popup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make budget editable
2 participants
@sidvishnoi @RabebOthmani