feat(popup): move WM toggle Switch to global header #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: popup
Extension builds preview
|
){kind=icon}
){kind=icon}
sidvishnoi
commented
Oct 10, 2024
Comment on lines
+51
to
+52
| title="Enable/Disable Web Monetization" | ||
| aria-label="Continuous payment stream" |
There was a problem hiding this comment.
What should we call these?
|
We decided to make this global switch to enable/disabled entire extension, not just continuous payments. |
|
Closing in favor of #773 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes proposed in this pull request
Move WM toggle switch to global header.
Visible only when wallet is connected, and in non-error state.
Screenshots:
Not visible in error state
Not visible when wallet not connected
Can toggle from any page
As of this PR, slider is still shown on payment page
This message can be improved