Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tests/e2e): rename environment variables #652

Merged
merged 2 commits into from
Oct 10, 2024
Merged

refactor(tests/e2e): rename environment variables #652

merged 2 commits into from
Oct 10, 2024

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Oct 10, 2024 •
edited
Loading

  1. Add TEST_WALLET_ prefix to test wallet related vars
  2. Add types for process.env
  3. Update location of .env file from tests/.env to tests/e2e/.env

@github-actions github-actions bot added area: documentation Improvements or additions to documentation area: ci Improvements or additions to repository workflows area: tests Improvements or additions to tests labels Oct 10, 2024
sidvishnoi
sidvishnoi commented Oct 10, 2024
View reviewed changes
Copy link
Member Author

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-e2e

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

Extension builds preview

Name Link
Latest commit c438a38
Latest job logs Run #11271293173
BadgeDownload
BadgeDownload

@sidvishnoi sidvishnoi mentioned this pull request Oct 10, 2024
Merged
raducristianpopa
raducristianpopa approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@raducristianpopa raducristianpopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning behind moving the .env file to tests/e2e?

@sidvishnoi
Copy link
Member Author

What's the reasoning behind moving the .env file to tests/e2e?

We've all e2e tests in tests/e2e, and script imports from root of e2e only. Docs were outdated to reflect that.

@sidvishnoi sidvishnoi merged commit fd44364 into main Oct 10, 2024
11 checks passed
@sidvishnoi sidvishnoi deleted the rename-ci-env-var-names branch October 10, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raducristianpopa raducristianpopa raducristianpopa approved these changes

Assignees
No one assigned
Labels
area: ci Improvements or additions to repository workflows area: documentation Improvements or additions to documentation area: tests Improvements or additions to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidvishnoi @raducristianpopa