-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(content/KeyAutoAdd): get output of any step, not just of previous #640
Conversation
Extension builds preview
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test-e2e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small additional comment: I would suggest adding the base URLs in environment variables. It would be easier to update them when the Test Wallet is going to move to the new domain.
I thought of doing that, until I found there's |
Simplifies KeyAutoAdd's step runner to let us get output of any step (that has been previously run), not just result of previous. Getting result of previous had limitation that any intermediate steps had to pass through data from previous steps. Now we store outputs in a Map and get those with the
output(fn)
helper (WeakMap not needed, as we store reference to function anyway in steps array).Also update signature of StepRun function.
Additionally, turn
skip
call to throw an instance ofSkipError
instead of object with symbol.