-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use esbuild instead of webpack for building #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Radu-Cristian Popa <[email protected]>
github-actions
bot
added
the
area: background
Improvements or additions to extension background script
label
Aug 12, 2024
Extension builds preview
|
github-actions
bot
added
the
area: popup
Improvements or additions to extension popup
label
Aug 13, 2024
sidvishnoi
changed the title
wip: try using esbuild
chore: use esbuild instead of webpack for building
Aug 13, 2024
github-actions
bot
added
area: documentation
Improvements or additions to documentation
area: ci
Improvements or additions to repository workflows
labels
Aug 13, 2024
Co-authored-by: Radu-Cristian Popa <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
- Fixes CSP issues in Firefox - Reduces bundle size again to webpack-like levels
It looks like the In the built monetization polyfill: function mr(t, r) {
if (g(r)) {
var n = L(r.length) | 0
return (t = F(t, n)), t.length === 0 || r.copy(t, 0, 0, n), t
}
if (r) {
if (
(typeof ArrayBuffer < 'u' && r.buffer instanceof ArrayBuffer) ||
'length' in r
)
return typeof r.length != 'number' || Yr(r.length) ? F(t, 0) : M(t, r)
if (r.type === 'Buffer' && J(r.data)) return M(t, r.data)
}
throw new TypeError(
'First argument must be a string, Buffer, ArrayBuffer, Array, or array-like object.'
)
}
function L(t) {
if (t >= d())
throw new RangeError(
'Attempt to allocate Buffer larger than maximum size: 0x' +
d().toString(16) +
' bytes'
)
return t | 0
}
a.isBuffer = Lr |
Co-authored-by: Radu-Cristian Popa <[email protected]>
raducristianpopa
force-pushed
the
rp/497/switch-to-proxy-injection
branch
from
August 16, 2024 12:33
cf71393
to
f7a2b0d
Compare
raducristianpopa
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done during pair-programming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: background
Improvements or additions to extension background script
area: ci
Improvements or additions to repository workflows
area: documentation
Improvements or additions to documentation
area: popup
Improvements or additions to extension popup
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #360
Changes proposed in this pull request
100KB20KB (#498 reduced by 80KB with mangling support)