fix(background/TabState): use tabId as tab isn't a live reference to tab
#437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: background
Extension builds preview
|
){kind=icon}
){kind=icon}
Does this work cross browser? |
sidvishnoi
changed the title
tabId as tab isn't a live reference to tab
sidvishnoi
reviewed
Jul 19, 2024
sidvishnoi
reviewed
Jul 19, 2024
sidvishnoi
reviewed
Jul 19, 2024
@dianafulga does it work same in Firefox? |
|
I checked and can confirm this works in Firefox also. |
sidvishnoi
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #286
Closes #287
The data is deleted immediately after the tab closes because reopening the tab (cmd + shift + T) will generate a new tabId anyway.