Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependencies #315

Closed
wants to merge 1 commit into from
Closed

chore(deps): update dependencies #315

wants to merge 1 commit into from

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Jun 10, 2024

Context

Instead of merging separate PRs and adding noise to commit log, maybe we should merge PRs combined weekly? This PR was generated with ncu. I've been using this approach on the open-source projects I maintain. We'd let dependabot/renovate generate PRs, but instead of merging each separately, we do this.

See also: #270

Changes proposed in this pull request

  1. Closes chore(deps): update node.js to v20.14.0 #225
  2. Closes chore(deps): update dependency @testing-library/react to v16 #304
  3. Closes chore(deps): update dependency css-loader to ^7.1.2 #308
  4. Closes chore(deps): update dependency eslint-plugin-react to ^7.34.2 #309
  5. Closes chore(deps): update dependency eslint-plugin-cypress to ^3.3.0 - autoclosed #310
  6. Closes chore(deps): update dependency eslint-webpack-plugin to ^4.2.0 #312
  7. Closes chore(deps): update dependency prettier-plugin-tailwindcss to ^0.6.4 #314
  8. and some more dependencies updated.

@sidvishnoi sidvishnoi added the dependencies Pull requests that update a dependency file label Jun 10, 2024
@raducristianpopa
Copy link
Member

Extension builds preview

Name Link
Latest commit 34f4fe7
Latest job logs Run #9449105029
BadgeDownload
BadgeDownload

@raducristianpopa
Copy link
Member

I don't think we should batch all the dependencies updates. This way, we can easily revert the PR if things are not going as planned.

@sidvishnoi
Copy link
Member Author

I'm of opinion that PR is the place where we check things are going right or not. Reverts are exceptional.
Besides, non-major dependency updates are considered safe enough.

I'm mostly concerned about the noise in git log. We've more dependency commits than actual code commits.

@sidvishnoi
Copy link
Member Author

From safety perspective, perhaps we can do certain updates (like open payments package) individually. Best of both?

@sidvishnoi
Copy link
Member Author

Closing the PR as most dependencies are merged already, but would like a discussion on reducing the dependency PR noise sometime soon.

@sidvishnoi sidvishnoi closed this Jun 13, 2024
@sidvishnoi sidvishnoi deleted the update-deps branch June 13, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants