Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add intent to background & split amount #307

Merged
merged 6 commits into from
Jun 11, 2024
Merged

feat: Add intent to background & split amount #307

merged 6 commits into from
Jun 11, 2024

Conversation

dianafulga
Copy link
Contributor

@dianafulga dianafulga commented Jun 6, 2024 •
edited by sidvishnoi
Loading

Closes #301
Closes #285

@github-actions github-actions bot added the area: background Improvements or additions to extension background script label Jun 6, 2024
@dianafulga dianafulga changed the title Add intent to background feat: Add intent to background Jun 6, 2024
@dianafulga dianafulga changed the title feat: Add intent to background feat: Add intent to background & split amount Jun 6, 2024
@raducristianpopa
Copy link
Member

raducristianpopa commented Jun 6, 2024 •
edited
Loading

Extension builds preview

Name Link
Latest commit 806cc90
Latest job logs Run #9454321435
BadgeDownload
BadgeDownload

This was linked to issues Jun 6, 2024
[Background] Delete sessions if intent set to delete from content script #301
Closed
[Background] Split sent amount #285
Closed
sidvishnoi
sidvishnoi reviewed Jun 6, 2024
View reviewed changes
src/background/services/monetization.ts Outdated Show resolved Hide resolved
src/background/services/monetization.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the area: content Improvements or additions to extension content script label Jun 10, 2024
@dianafulga dianafulga requested a review from sidvishnoi June 10, 2024 12:04
sidvishnoi
sidvishnoi requested changes Jun 10, 2024
View reviewed changes
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little bug to squash there..

@dianafulga dianafulga requested a review from sidvishnoi June 10, 2024 19:20
@dianafulga dianafulga merged commit d091c53 into main Jun 11, 2024
8 checks passed
@dianafulga dianafulga deleted the df--split-amount branch June 11, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidvishnoi sidvishnoi sidvishnoi approved these changes

@raducristianpopa raducristianpopa Awaiting requested review from raducristianpopa

Assignees
No one assigned
Labels
area: background Improvements or additions to extension background script area: content Improvements or additions to extension content script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Background] Delete sessions if intent set to delete from content script [Background] Split sent amount
3 participants
@dianafulga @raducristianpopa @sidvishnoi