feat: calculate rate of pay slider values for different assets #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raducristianpopa
changed the title
github-actions
bot
added
the
area: background
Extension builds preview
|
){kind=icon}
){kind=icon}
raducristianpopa
force-pushed
the
rp/142/calculate-rate-of-pay
branch
from
d34ede0 to
e01c8c9
Compare
dianafulga
approved these changes
Apr 15, 2024
|
|
||
| export const getExchangeRates = async (): Promise<ExchangeRates> => { | ||
| const response = await fetch( | ||
| 'https://telemetry-exchange-rates.s3.amazonaws.com/exchange-rates-usd.json' |
There was a problem hiding this comment.
I think we have hardcoded url in a few places, maybe we should move them into an env/config file or
There was a problem hiding this comment.
Will move it in #231.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #142.
Changes proposed in this pull request