-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add open payments sdk #100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: background
Improvements or additions to extension background script
area: popup
Improvements or additions to extension popup
labels
Feb 15, 2024
github-actions
bot
removed
the
area: popup
Improvements or additions to extension popup
label
Feb 15, 2024
raducristianpopa
force-pushed
the
rp--open-payments-sdk
branch
from
February 20, 2024 13:13
2d633fc
to
3e3cd90
Compare
github-actions
bot
added
the
area: content
Improvements or additions to extension content script
label
Feb 21, 2024
id: keyId, | ||
alg: 'ed25519', | ||
async sign(data: Uint8Array) { | ||
return Buffer.from(await ed.signAsync(data, key.slice(16))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sign
method in @noble/ed25519
only needs the value of the private key for signing a message. The leading 16 bytes denote the PKCS#8 version and algorithm, and the rest of the bytes represent the private key value.
github-actions
bot
added
the
area: popup
Improvements or additions to extension popup
label
Feb 23, 2024
raducristianpopa
force-pushed
the
rp--open-payments-sdk
branch
from
February 23, 2024 06:17
fdae0cf
to
d6381ad
Compare
dianafulga
previously approved these changes
Feb 23, 2024
dianafulga
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: background
Improvements or additions to extension background script
area: content
Improvements or additions to extension content script
area: popup
Improvements or additions to extension popup
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #95.
Changes proposed in this pull request
Replaces current OP requests with the OP SDK.