Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add open payments sdk #100

Merged
merged 20 commits into from
Feb 27, 2024
Merged

feat: add open payments sdk #100

merged 20 commits into from
Feb 27, 2024

Conversation

raducristianpopa
Copy link
Member

@raducristianpopa raducristianpopa commented Feb 15, 2024

Context

Closes #95.

Changes proposed in this pull request

Replaces current OP requests with the OP SDK.

@github-actions github-actions bot added area: background Improvements or additions to extension background script area: popup Improvements or additions to extension popup labels Feb 15, 2024
@raducristianpopa
Copy link
Member Author

raducristianpopa commented Feb 15, 2024

Extension builds preview

Name Link
Latest commit a52651a
Latest job logs Run #8045022166
BadgeDownload
BadgeDownload
BadgeDownload
BadgeDownload

@github-actions github-actions bot removed the area: popup Improvements or additions to extension popup label Feb 15, 2024
@github-actions github-actions bot added the area: content Improvements or additions to extension content script label Feb 21, 2024
webpack.config.utils.ts Outdated Show resolved Hide resolved
src/manifest/chrome.json Show resolved Hide resolved
src/background/container.ts Outdated Show resolved Hide resolved
id: keyId,
alg: 'ed25519',
async sign(data: Uint8Array) {
return Buffer.from(await ed.signAsync(data, key.slice(16)))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sign method in @noble/ed25519 only needs the value of the private key for signing a message. The leading 16 bytes denote the PKCS#8 version and algorithm, and the rest of the bytes represent the private key value.

@raducristianpopa raducristianpopa marked this pull request as ready for review February 22, 2024 06:07
@github-actions github-actions bot added the area: popup Improvements or additions to extension popup label Feb 23, 2024
dianafulga
dianafulga previously approved these changes Feb 23, 2024
webpack.config.utils.ts Outdated Show resolved Hide resolved
src/manifest/chrome.json Show resolved Hide resolved
@raducristianpopa raducristianpopa merged commit 5cad493 into main Feb 27, 2024
9 checks passed
@raducristianpopa raducristianpopa deleted the rp--open-payments-sdk branch February 27, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: background Improvements or additions to extension background script area: content Improvements or additions to extension content script area: popup Improvements or additions to extension popup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the Open Payments SDK
2 participants