Skip to content

Commit

Permalink
add missing copy in messages.json; add some descriptions; nits
Browse files Browse the repository at this point in the history
  • Loading branch information
sidvishnoi committed Sep 23, 2024
1 parent 09a2f4a commit 5492262
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
10 changes: 6 additions & 4 deletions src/_locales/en/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"message": "Let's get you set up!"
},
"connectWallet_text_desc": {
"message": ""
"message": "Just a few quick steps to connect the extension to your wallet"
},
"connectWallet_label_walletAddress": {
"message": "Enter your wallet address or payment pointer"
Expand All @@ -119,15 +119,16 @@
"message": "We'll automatically add a key-pair with your wallet provider."
},
"connectWallet_text_autoPublicKeyNoticeLearnMore": {
"message": "Learn more"
"message": "Learn more",
"description": "Learn more about how this works"
},
"connectWallet_error_urlRequired": {
"message": "Wallet address is required."
},
"connectWallet_error_urlInvalidUrl": {
"message": "Invalid wallet address URL."
},
"connectWallet_error_urlInvalidUrlHttps": {
"connectWallet_error_urlInvalidNotHttps": {
"message": "Wallet address must be a https:// URL or a payment pointer.'"
},
"connectWallet_error_amountRequired": {
Expand All @@ -146,7 +147,8 @@
"message": "We couldn't automatically share the key-pair with your provider."
},
"connectWallet_error_failedAutoKeyAddWhy": {
"message": "Why?"
"message": "Why?",
"description": "Clicking this will show reason for why automatic key-adding failed."
},
"connectWallet_error_invalidClient": {
"message": "Failed to connect. Please make sure you have added the key to the correct wallet address."
Expand Down
2 changes: 1 addition & 1 deletion src/popup/components/ConnectWalletForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ function validateWalletAddressUrl(value: string): '' | ErrorCodeUrl {
}

if (url.protocol !== 'https:') {
return 'connectWallet_error_urlInvalidUrlHttps';
return 'connectWallet_error_urlInvalidNotHttps';
}

return '';
Expand Down

0 comments on commit 5492262

Please sign in to comment.