fix: set the value from incoming payment in quote #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragosp1011
requested review from
raducristianpopa,
domin191013,
beniaminmunteanu and
Tymmmy
github-actions
bot
added
package: wallet/backend
| amount: value | ||
| }) | ||
| let convertedValue | ||
| if (isIncomingPayment) { |
There was a problem hiding this comment.
I'm not sure about this approach. The users should be able send their desired amounts. If the incoming payment has a receive amount of 100EUR, we should not enforce to send 100EUR.
There was a problem hiding this comment.
Yep, I agree, the request might be 100EUR but the user ca decide to pay only 50EUR
There was a problem hiding this comment.
the issue is that converting the value is not exact, so 20.15 euro will result in 100.02 roni (instead of expected 100)
I added a check that if the amount is off by less then 1% to set it to the amount in incoming payment
open to other suggestions if this does not make sense
beniaminmunteanu
previously approved these changes
Oct 13, 2023
…currency-fixed-send
beniaminmunteanu
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes
this PR will solve issues with internal cross-currencies payments.
External payments may still encounter this issue and it will be solved when Create
GetReceiverGraphQL Admin Query rafiki#1005 will be implemented.