feat: add additional details for card transactions

packages/wallet/backend/migrations/20241217130555_add_card_tx_details_to_transactions.js

@@ -0,0 +1,25 @@
+/**
+ * @param { import("knex").Knex } knex
+ * @returns { Promise<void> }
+ */
+exports.up = function (knex) {
+  return knex.schema.table('transactions', function (table) {
+    table.bigint('txAmount').nullable()
+    table.string('txCurrency').nullable()
+    table.string('conversionRate').nullable()
+    table.integer('cardTxType').nullable()
+  })
+}
+
+/**
+ * @param { import("knex").Knex } knex
+ * @returns { Promise<void> }
+ */
+exports.down = function (knex) {
+  return knex.schema.table('transactions', function (table) {
+    table.dropColumn('txAmount')
+    table.dropColumn('txCurrency')
+    table.dropColumn('conversionRate')
+    table.dropColumn('cardTxType')
+  })
+}

packages/wallet/backend/src/transaction/model.ts

@@ -32,6 +32,10 @@ export class Transaction
   value!: bigint | null
   walletAddress!: WalletAddress
   isCard?: boolean
+  txAmount?: bigint
+  txCurrency?: string
+  conversionRate?: string
+  cardTxType?: number
 
   // Merchant name for card transactions
   // Receiver or sender WA for ilp payments

packages/wallet/backend/src/transaction/service.ts

@@ -168,6 +168,13 @@ export class TransactionService implements ITransactionService {
           status: 'COMPLETED',
           description: '',
           isCard: true,
+          secondParty: transaction.merchantName,
+          txAmount: transaction.transactionAmount
+            ? transformBalance(Number(transaction.transactionAmount), 2)
+            : undefined,
+          conversionRate: transaction.mastercardConversion?.convRate,
+          txCurrency: transaction.transactionCurrency,
+          cardTxType: transaction.type,
           createdAt: new Date(transaction.createdAt)
         })
       )

packages/wallet/backend/tests/gatehub/service.test.ts

@@ -443,11 +443,9 @@ describe('GateHub Service', (): void => {
           { email: '[email protected]' }
         ])
 
-        const result = await gateHubService.addUserToGateway(user.id)
-        expect(result).toEqual({
-          customerId: undefined,
-          isApproved: undefined
-        })
+        expect(gateHubService.addUserToGateway(user.id)).rejects.toThrowError(
+          `GateHub user with email ${user.email} not found`
+        )
       })
     })
   })

packages/wallet/shared/src/types/card.ts

@@ -1,3 +1,5 @@
+import { CardTrxTypeEnum } from './transaction'
+
 export type LockReasonCode =
   | 'ClientRequestedLock'
   | 'LostCard'
@@ -34,7 +36,7 @@ export interface ICardTransaction {
   transactionId: string
   ghResponseCode: string
   cardScheme: number
-  type: number
+  type: CardTrxTypeEnum
   createdAt: string
   txStatus: string
   vaultId: number
@@ -49,6 +51,10 @@ export interface ICardTransaction {
   wallet: number
   transactionDateTime: string
   processDateTime: string | null
+  merchantName?: string
+  mastercardConversion?: {
+    convRate?: string
+  }
 }
 
 export interface IPagination {

packages/wallet/shared/src/types/transaction.ts

@@ -12,6 +12,22 @@ enum TRANSACTION_STATUS {
 }
 type TransactionStatus = keyof typeof TRANSACTION_STATUS
 
+export enum CardTrxTypeEnum {
+  Purchase = 0,
+  ATMWithdrawal = 1,
+  CardVerificationInquiry = 6,
+  CashAdvance = 17,
+  RefundCreditPayment = 20,
+  BalanceInquiryOnATM = 30,
+  PINUnblock = 91,
+  PINChange = 92,
+  Preauthorization = 101,
+  PreauthorizationIncremental = 102,
+  PreauthorizationCompletion = 103,
+  TransferToAccount = 107,
+  TransferFromAccount = 108
+}
+
 export interface TransactionResponse {
   id: string
   paymentId: string
@@ -24,6 +40,10 @@ export interface TransactionResponse {
   // Merchant name for card transactions
   // Receiver or sender WA for ilp payments
   secondParty?: string
+  txAmount?: bigint
+  txCurrency?: string
+  conversionRate?: string
+  cardTxType?: CardTrxTypeEnum
   createdAt: Date
   updatedAt: Date
 }