Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): inverted rate #3165

Merged
merged 1 commit into from
Dec 7, 2024
Merged

fix(backend): inverted rate #3165

merged 1 commit into from
Dec 7, 2024

Conversation

BlairCurrey
Copy link
Contributor

Changes proposed in this pull request

  • updates rate calculation to not invert

Context

fixes #3163

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@BlairCurrey BlairCurrey requested a review from mkurapov December 6, 2024 21:12
@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. type: source Changes business logic labels Dec 6, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 6, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit 620549f
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/675368d3fe98a900088a8b06

@BlairCurrey BlairCurrey merged commit 5c21c94 into main Dec 7, 2024
29 of 42 checks passed
@BlairCurrey BlairCurrey deleted the bc/3163/fix-rate-calc branch December 7, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurapov mkurapov mkurapov approved these changes

Assignees
No one assigned
Labels
pkg: backend Changes in the backend package. type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calculating fixed delivery quotes for different asset scales results in wrong exchange rate
2 participants
@BlairCurrey @mkurapov