Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added missing responses to id-provider requests #3024

Merged
merged 2 commits into from
Oct 14, 2024
Merged

docs: added missing responses to id-provider requests #3024

merged 2 commits into from
Oct 14, 2024

Conversation

oana-lolea
Copy link
Contributor

Changes proposed in this pull request

  • Added missing response codes to id-provider specs

Context

After reviewing all the OpenAPI specs, I have found two missing response statuses in the id-provider.yaml:

  • 500 code at the request that starts the user interaction
  • 404 code at the request that finishes the user interaction

Fixes #2958

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@oana-lolea oana-lolea requested a review from mkurapov October 9, 2024 09:26
@github-actions github-actions bot added type: source Changes business logic pkg: auth Changes in the GNAP auth package. labels Oct 9, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 9, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit c4cbe19
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/670941cad99063000855ac38

@oana-lolea oana-lolea merged commit 3470ba4 into main Oct 14, 2024
30 of 42 checks passed
@oana-lolea oana-lolea deleted the 2958-review-openapi-specs branch October 14, 2024 10:03
@njlie njlie mentioned this pull request Nov 8, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurapov mkurapov mkurapov approved these changes

Assignees
No one assigned
Labels
pkg: auth Changes in the GNAP auth package. type: source Changes business logic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Technical review of OpenAPI specs
2 participants
@oana-lolea @mkurapov