feat(migrations): support for running database migrations manually #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pkg: backend
✅ Deploy Preview for brilliant-pasca-3e80ec canceled.
|
golobitch
force-pushed
the
fix/2621-db-migrations-k8s
branch
3 times, most recently
from
42d4eb6 to
ad4cd3c
Compare
golobitch
commented
Mar 30, 2024
| @@ -17,6 +17,7 @@ RUN --mount=type=cache,id=pnpm,target=/pnpm/store \ | |||
| FROM base AS prod-deps | |||
|
|
|||
| COPY package.json pnpm-workspace.yaml .npmrc ./ | |||
| COPY packages/auth/knexfile.js ./packages/auth/knexfile.js | |||
There was a problem hiding this comment.
this line here is not really needed (same for packages/backend/Dockerfile however, I like consistency (line #55)
golobitch
force-pushed
the
fix/2621-db-migrations-k8s
branch
from
ad4cd3c to
1213094
Compare
dragosp1011
approved these changes
Apr 1, 2024
|
This PR has been approved, however, I am not authorized to merge this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
ENABLE_MANUAL_MIGRATIONSthrough which end user can decide if he/she wants to run migrations automatically (default flow as it always was) or manually (pnpm run knex -- migrate:latest --env productionknexfile.jsuse env variable from the ENV for setting connection string for production environmentWith this in place, if Rafiki is installed on kubernetes cluster, it is possible to leverage initContainers for database migrations. This should be backward compatible or in other words, should not change how Rafiki deals with database migrations when default values for this environment variable is set.
Context
fixes #2621
After this PR is merged, we will need to implement this ENV into helm charts. After this ENV is added to helm charts, we need to set value to
true, and we will also need to specify initContainer that will run this migrations "manually" or in other words, automatically in initContainer.Checklist
fixes #number