Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update remix monorepo to ^2.8.1 - autoclosed #2439

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 21, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@remix-run/dev (source) ^2.6.0 -> ^2.8.1 age adoption passing confidence
@remix-run/eslint-config (source) ^2.6.0 -> ^2.8.1 age adoption passing confidence
@remix-run/node (source) ^2.6.0 -> ^2.8.1 age adoption passing confidence
@remix-run/react (source) ^2.6.0 -> ^2.8.1 age adoption passing confidence
@remix-run/serve (source) ^2.6.0 -> ^2.8.1 age adoption passing confidence

Release Notes

remix-run/remix (@​remix-run/dev)

v2.8.1

Compare Source

Patch Changes
  • Support reading from Vite config when running remix reveal and remix routes CLI commands (#​8916)
  • Add Vite commands to Remix CLI --help output (#​8939)
  • Vite: Fix support for build.sourcemap option in Vite config (#​8965)
  • Clean up redundant client route query strings on route JavaScript files in production builds (#​8969)
  • Vite: Fix error when using Vite's server.fs.allow option without a client entry file (#​8966)
  • Updated dependencies:

v2.8.0

Compare Source

Minor Changes
  • Pass resolved viteConfig to Remix Vite plugin's buildEnd hook (#​8885)
Patch Changes
  • Mark Layout as browser safe route export in esbuild compiler (#​8842)
  • Vite: Silence build warnings when dependencies include "use client" directives (#​8897)
  • Vite: Fix serverBundles issue where multiple browser manifests are generated (#​8864)
  • Support custom Vite build.assetsDir option (#​8843)
  • Updated dependencies:

v2.7.2

Compare Source

Patch Changes

v2.7.1

Compare Source

Patch Changes

v2.7.0

Compare Source

Minor Changes
  • Allow an optional Layout export from the root route (#​8709)

  • Vite: Cloudflare Proxy as a Vite plugin (#​8749)

    This is a breaking change for projects relying on Cloudflare support from the unstable Vite plugin

    The Cloudflare preset (unstable_cloudflarePreset) as been removed and replaced with a new Vite plugin:

     import {
        unstable_vitePlugin as remix,
    -   unstable_cloudflarePreset as cloudflare,
    +   cloudflareDevProxyVitePlugin as remixCloudflareDevProxy,
      } from "@​remix-run/dev";
      import { defineConfig } from "vite";
    
      export default defineConfig({
        plugins: [
    +     remixCloudflareDevProxy(),
    +     remix(),
    -     remix({
    -       presets: [cloudflare()],
    -     }),
        ],
    -   ssr: {
    -     resolve: {
    -       externalConditions: ["workerd", "worker"],
    -     },
    -   },
      });

    remixCloudflareDevProxy must come before the remix plugin so that it can override Vite's dev server middleware to be compatible with Cloudflare's proxied environment.

    Because it is a Vite plugin, remixCloudflareDevProxy can set ssr.resolve.externalConditions to be workerd-compatible for you.

    remixCloudflareDevProxy accepts a getLoadContext function that replaces the old getRemixDevLoadContext.
    If you were using a nightly version that required getBindingsProxy or getPlatformProxy, that is no longer required.
    Any options you were passing to getBindingsProxy or getPlatformProxy should now be passed to remixCloudflareDevProxy instead.

    This API also better aligns with future plans to support Cloudflare with a framework-agnostic Vite plugin that makes use of Vite's (experimental) Runtime API.

  • Vite: Stabilize the Remix Vite plugin, Cloudflare preset, and all related types by removing all unstable_ / Unstable_ prefixes. (#​8713)

    While this is a breaking change for existing Remix Vite plugin consumers, now that the plugin has stabilized, there will no longer be any breaking changes outside of a major release. Thank you to all of our early adopters and community contributors for helping us get here! 🙏

  • Vite: Stabilize "SPA Mode" by renaming the Remix vite plugin config from unstable_ssr -> ssr (#​8692)

  • Vite: Add a new basename option to the Vite plugin, allowing users to set the internal React Router basename in order to to serve their applications underneath a subpath (#​8145)

Patch Changes
  • Vite: fix server exports dead-code elimination for routes outside of app directory (#​8795)

  • Always prepend DOCTYPE in SPA mode entry.server.tsx, can opt out via remix reveal (#​8725)

  • Fix build issue in SPA mode when using a basename (#​8720)

  • Vite: Validate that the MDX Rollup plugin, if present, is placed before Remix in Vite config (#​8690)

  • Vite: reliably detect non-root routes in Windows (#​8806)

    Sometimes route file will be unnormalized Windows path with \ instead of /.

  • Vite: Pass remixUserConfig to preset remixConfig hook (#​8797)

  • Vite: Fix issue resolving critical CSS during development when the current working directory differs from the project root (#​8752)

  • Vite: Ensure CSS file URLs that are only referenced in the server build are available on the client (#​8796)

  • Vite: Require version 5.1.0 to support .css?url imports (#​8723)

  • Fix type error in Remix config for synchronous routes function (#​8745)

  • Vite: Support Vite v5.1.0's .css?url imports (#​8684)

  • Always ignore route files starting with . (#​8801)

  • Vite: Enable use of vite preview to preview Remix SPA applications (#​8624)

    • In the SPA template, npm run start has been renamed to npm run preview which uses vite preview instead of a standalone HTTP server such as http-server or serv-cli
  • Vite: Remove the ability to pass publicPath as an option to the Remix vite plugin (#​8145)

    • ⚠️ This is a breaking change for projects using the unstable Vite plugin with a publicPath
    • This is already handled in Vite via the base config so we now set the Remix publicPath from the Vite base config
  • Vite: Fix issue where client route file requests fail if search params have been parsed and serialized before reaching the Remix Vite plugin (#​8740)

  • Vite: Enable HMR for .md and .mdx files (#​8711)

  • Updated dependencies:

remix-run/remix (@​remix-run/eslint-config)

v2.8.1

Compare Source

No significant changes to this package were made in this release. See the repo CHANGELOG.md for an overview of all changes in v2.8.1.

v2.8.0

Compare Source

No significant changes to this package were made in this release. See the repo CHANGELOG.md for an overview of all changes in v2.8.0.

v2.7.2

Compare Source

v2.7.1

Compare Source

v2.7.0

Compare Source

remix-run/remix (@​remix-run/node)

v2.8.1

Compare Source

Patch Changes

v2.8.0

Compare Source

Patch Changes

v2.7.2

Compare Source

Patch Changes

v2.7.1

Compare Source

Patch Changes

v2.7.0

Compare Source

Patch Changes
remix-run/remix (@​remix-run/react)

v2.8.1

Compare Source

Patch Changes
  • Strengthen the internal LayoutComponent type to accept limited children (#​8910)
  • Updated dependencies:

v2.8.0

Compare Source

Patch Changes
  • Fix the default root ErrorBoundary component so it leverages the user-provided Layout component (#​8859)
  • Fix the default root HydrateFallback component so it leverages any user-provided Layout component (#​8892)
  • Ensure @remix-run/react re-exports everything from react-router-dom for SPA mode (#​8929)
  • Updated dependencies:

v2.7.2

Compare Source

Patch Changes

v2.7.1

Compare Source

Patch Changes

v2.7.0

Compare Source

Minor Changes
  • Allow an optional Layout export from the root route (#​8709)
  • Vite: Add a new basename option to the Vite plugin, allowing users to set the internal React Router basename in order to to serve their applications underneath a subpath (#​8145)
Patch Changes
remix-run/remix (@​remix-run/serve)

v2.8.1

Compare Source

Patch Changes

v2.8.0

Compare Source

Patch Changes

v2.7.2

Compare Source

Patch Changes

v2.7.1

Compare Source

Patch Changes

v2.7.0

Compare Source

Patch Changes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Pull requests that update a dependency label Feb 21, 2024
@github-actions github-actions bot added pkg: frontend Changes in the frontend package. pkg: mock-ase labels Feb 21, 2024
Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for brilliant-pasca-3e80ec canceled.

Name Link
🔨 Latest commit eb8c3ea
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/66056e8e6e014800080edff5

@renovate renovate bot force-pushed the renovate-remix-monorepo branch 2 times, most recently from 151dd5e to 854a004 Compare February 28, 2024 10:32
@renovate renovate bot changed the title chore(deps): update remix monorepo to ^2.7.2 chore(deps): update remix monorepo to ^2.8.0 Feb 28, 2024
@renovate renovate bot force-pushed the renovate-remix-monorepo branch 7 times, most recently from 2095d06 to 3bc407e Compare March 5, 2024 09:26
@renovate renovate bot force-pushed the renovate-remix-monorepo branch 4 times, most recently from ffb567c to c6eac5a Compare March 7, 2024 13:22
@sabineschaller
Copy link
Member

@JoblersTune can you have a look?

@renovate renovate bot force-pushed the renovate-remix-monorepo branch from c6eac5a to e53c66a Compare March 7, 2024 18:33
@renovate renovate bot changed the title chore(deps): update remix monorepo to ^2.8.0 chore(deps): update remix monorepo to ^2.8.1 Mar 7, 2024
@renovate renovate bot force-pushed the renovate-remix-monorepo branch from e53c66a to bb3e7df Compare March 8, 2024 12:20
@JoblersTune
Copy link
Collaborator

@sabineschaller it seems like the issue is coming in with the "@remix-run/dev": "^2.6.0", upgrade. I'm trying to see if I can find a solution. The problem already comes in when upgrading to version 2.7 so it's not only the latest release.
The other dependencies can be upgraded without an issue.

@JoblersTune
Copy link
Collaborator

Have submitted an issue about the type issues in the node_modules folder that happen in version 2.7 and 2.8 of remix-run/dev package.

@JoblersTune JoblersTune added the do not merge Do not merge PRs with these label label Mar 11, 2024
@BlairCurrey
Copy link
Contributor

BlairCurrey commented Mar 11, 2024

I see that he suggested using skipLibCheck: true. I was hopeful that we could resolve the underlying issue but after digging into it more I think we might need to use that flag. It's also been default in TS since 3.9. Reading more about the issue leading up to enabling skipLibCheck by default, I'm not sure there is really any type safety lost - anything actually imported into our code is still getting checked and the checks only apply to declaration files.

It seems the root cause are unmet @remix-run/dev peerDependencies: vite 5.1.3 and wrangler ^3.28.2. If you inspect our package-lock.yaml you'll see that we have a vite v4 (from astro or @remix-run/dev subdependency @vanilla-extract/integration, cant tell which) but no version of wrangler which is why we see these warnings. Note that these peerDependencies are marked as optional in the peerDependencyMeta. Looks like vite is optional because it's an alternate compiler (first paragraph) and wrangler appears related to a cloudflare plugin (neither of which we use AFAIK).

We can resolve these errors by explicitly adding vite 5.1.3 and the latest wrangler to our frontend dependencies. Then remix will use those dependencies, but I found more errors lurking behind them: 1 for vite related to the typescript moduleResolution setting which seemed non-trivial and 89 for wrangler (maybe required more of the optional peer dependencies?).

@JoblersTune
Copy link
Collaborator

JoblersTune commented Mar 12, 2024

Since it's not on their road map to resolve these type issues then I am also in favour of using skipLibCheck and moving forward.
I'll add it now.
The question is, shall I add it across all packages? Or just frontend where we are having issues?

@renovate renovate bot force-pushed the renovate-remix-monorepo branch from 6a5137b to 1211aa4 Compare March 12, 2024 10:33
@BlairCurrey
Copy link
Contributor

More opinions are definitely welcome (because it does look like it's recommend as a default many places) but it might be safer to leave it off everywhere else for now. I'm comforted by some investigation that suggests its really not a problem here but not sure I'd want to pre-emptively hide future cases. just my 2 cents

@JoblersTune
Copy link
Collaborator

The next issue now seems to be a version incompatibility for eslint-plugin-jsx-a11y but we are already using the most up to date version which was released 4 months ago.

@renovate renovate bot force-pushed the renovate-remix-monorepo branch 9 times, most recently from 8b13b81 to b7da17a Compare March 20, 2024 13:20
@renovate renovate bot force-pushed the renovate-remix-monorepo branch 4 times, most recently from 39e0338 to 132fdb0 Compare March 28, 2024 13:11
@renovate renovate bot force-pushed the renovate-remix-monorepo branch from 132fdb0 to eb8c3ea Compare March 28, 2024 13:20
@renovate renovate bot changed the title chore(deps): update remix monorepo to ^2.8.1 chore(deps): update remix monorepo to ^2.8.1 - autoclosed Apr 3, 2024
@renovate renovate bot closed this Apr 3, 2024
@renovate renovate bot deleted the renovate-remix-monorepo branch April 3, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency do not merge Do not merge PRs with these label pkg: frontend Changes in the frontend package. pkg: mock-ase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants