Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update mermaid implementation #2237

Merged
merged 1 commit into from
Nov 29, 2023
Merged

refactor: update mermaid implementation #2237

merged 1 commit into from
Nov 29, 2023

Conversation

huijing
Copy link
Contributor

@huijing huijing commented Nov 29, 2023

Changes proposed in this pull request

Context

Closes #2235

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass
  • Postman collection updated

@netlify Netlify
Copy link

netlify bot commented Nov 29, 2023 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec ready!

Name Link
🔨 Latest commit c3ac377
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/656744b21a39df0008959aba
😎 Deploy Preview https://deploy-preview-2237--brilliant-pasca-3e80ec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added pkg: documentation Changes in the documentation package. type: documentation (archived) Improvements or additions to documentation labels Nov 29, 2023
sabineschaller
sabineschaller approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@sabineschaller sabineschaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see correct mermaid diagrams. Looks good! I can't comment on anything else frontend related 😉

@huijing huijing merged commit 89272d3 into main Nov 29, 2023
21 checks passed
@huijing huijing deleted the chj/2235/update-mermaid-implementation branch November 29, 2023 14:49
beniaminmunteanu pushed a commit that referenced this pull request Dec 4, 2023
@huijing @beniaminmunteanu
Update mermaid implementation (#2237)
f8f2c57
@huijing huijing mentioned this pull request Dec 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabineschaller sabineschaller sabineschaller approved these changes

Assignees
No one assigned
Labels
pkg: documentation Changes in the documentation package. type: documentation (archived) Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Mermaid implementation
2 participants
@huijing @sabineschaller