feat(backend): remove payment pointer from url, retrieve it from request query or body

[njlie]

Changes proposed in this pull request

• Removes the payment pointer from the path of subresource and collection requests on wallet addresses.
• Retrieves the wallet address from the query params if it is a GET request or from the request body if it is a POST request on a subresource/collection.

Context

Fixes #1939.

Checklist

• Related issues linked using fixes #number
• Tests added/updated
• Documentation added
• Make sure that all checks pass
• Postman collection updated

[njlie]

Fixing some typos in the migration

[sabineschaller]

What is walletaddresskeys_walletaddressid_foreign?

[njlie]

It's a foreign key on the table walletAddressKeys that links it to walletAddress via its id property. The line referenced here is the rollback for this migration, so it's part of reverting the foreign key from referring to wallet addresses to payment pointers.

[sabineschaller]

I'm assuming the connection part is going to be removed in a subsequent PR from @BlairCurrey ?

[njlie]

That's correct.

[BlairCurrey]

This part will actually still be here but with a paired down connection type. After talking w/ Max our plan was to leave the connection service because we still need to get credentials from the stream server. So we will just have ConnectionService.get that returns something like this (and getting rid of the current Connection model):

{
  ilpAddress: IlpAddress
  sharedSecret: Buffer
}

So internally we still have some concept of connections but they are basically just the stream credentials. I could probably see a case for putting this somewhere in IncomingPaymentsService or the model but for now this is the simpler refactor.

EDIT: we have since decided to change this to rename this to streamCredentialService

[BlairCurrey]

I think the createQuote needs to get the walletAddress from body now, instead of ctx.

rafiki/packages/backend/src/open_payments/quote/routes.ts

Lines 63 to 71 in 2bba62b

	async function createQuote(
	deps: ServiceDependencies,
	ctx: CreateContext<CreateBody>
	): Promise<void> {
	const { body } = ctx.request
	const options: CreateQuoteOptions = {
	walletAddressId: ctx.walletAddress.id,
	receiver: body.receiver,
	client: ctx.client

[njlie]

I updated the middleware file to get walletAddress from the body or query when it adds it to the context, so the actual route handlers can still grab walletAddress from the context.

For some routes (e.g. GET /incoming-payments/:id) the identifier is enough to get the payment, so we just return the walletAddress that's fetched along with the payyment.

[BlairCurrey]

Some usages of paymentPointer snuck back in when reintroducing those lost commits (noticed on my branch as well):

rafiki/packages/backend/src/open_payments/payment/incoming/routes.test.ts

Lines 297 to 329 in 646d1dc

	describe('get unauthenticated incoming payment', (): void => {
	test('Can get incoming payment with public fields', async (): Promise<void> => {
	const incomingPayment = await createIncomingPayment(deps, {
	paymentPointerId: paymentPointer.id,
	expiresAt,
	incomingAmount,
	metadata
	})
	const ctx = setup<ReadContextWithAuthenticatedStatus>({
	reqOpts: {
	headers: { Accept: 'application/json' },
	method: 'GET',
	url: `/incoming-payments/${incomingPayment.id}`
	},
	params: {
	id: incomingPayment.id
	},
	paymentPointer
	})
	ctx.authenticated = false
	await expect(incomingPaymentRoutes.get(ctx)).resolves.toBeUndefined()
	expect(ctx.response).toSatisfyApiSpec()
	expect(ctx.body).toEqual({
	receivedAmount: {
	value: '0',
	assetCode: asset.code,
	assetScale: asset.scale
	}
	})
	})
	})

rafiki/packages/backend/src/open_payments/payment/incoming/routes.ts

Line 84 in 646d1dc

paymentPointerId: ctx.paymentPointer.id

rafiki/packages/backend/src/open_payments/wallet_address/middleware.ts

Line 24 in 646d1dc

ctx.walletAddressUrl = `https://${ctx.request.host}/${ctx.params.paymentPointerPath}`

rafiki/postman/collections/Interledger.json

Lines 1653 to 1655 in 646d1dc

	"raw": "{{pfryPaymentPointer}}/incoming-payments/{{incomingPaymentId}}",
	"host": [
	"{{pfryPaymentPointer}}"

[BlairCurrey]

Looks good. I'm seeing 18 build errors, all related to my connection/payment methods changes which are fixed on my branch. Migrations running and everything.