feat(telemetry): update tests

packages/backend/src/index.ts

@@ -49,7 +49,7 @@ import { createIlpPaymentService } from './payment-method/ilp/service'
 import { createSPSPRoutes } from './payment-method/ilp/spsp/routes'
 import { createStreamCredentialsService } from './payment-method/ilp/stream-credentials/service'
 import { createRatesService } from './rates/service'
-import { createTelemetryService } from './telemetry/service'
+import { TelemetryService, createTelemetryService } from './telemetry/service'
 import { createWebhookService } from './webhook/service'
 
 BigInt.prototype.toJSON = function () {
@@ -355,6 +355,10 @@ export function initIocContainer(
 
   container.singleton('connectorApp', async (deps) => {
     const config = await deps.use('config')
+    let telemetry: TelemetryService | undefined
+    if (config.enableTelemetry) {
+      telemetry = await deps.use('telemetry')
+    }
     return await createConnectorService({
       logger: await deps.use('logger'),
       redis: await deps.use('redis'),
@@ -365,7 +369,7 @@ export function initIocContainer(
       ratesService: await deps.use('ratesService'),
       streamServer: await deps.use('streamServer'),
       ilpAddress: config.ilpAddress,
-      telemetry: await deps.use('telemetry')
+      telemetry
     })
   })
 

packages/backend/src/payment-method/ilp/connector/core/test/middleware/telemetry.test.ts

@@ -1,10 +1,11 @@
 import assert from 'assert'
-import { OutgoingAccount, ZeroCopyIlpPrepare } from '../..'
+import { IlpResponse, OutgoingAccount, ZeroCopyIlpPrepare } from '../..'
 import { IncomingAccountFactory, RafikiServicesFactory } from '../../factories'
 import { createTelemetryMiddleware } from '../../middleware/telemetry'
 import { createILPContext } from '../../utils'
 
 import * as telemetry from '../../../../../../telemetry/transaction-amount'
+import { IlpFulfill } from 'ilp-packet'
 
 const incomingAccount = IncomingAccountFactory.build({ id: 'alice' })
 
@@ -28,7 +29,10 @@ const ctx = createILPContext({
     incomingAccount: {
       quote: 'exists'
     }
-  }
+  },
+  response: {
+    fulfill: 'exists' as unknown as IlpFulfill
+  } as IlpResponse
 })
 
 jest.mock('../../../../../../telemetry/transaction-amount')
@@ -60,8 +64,8 @@ describe('Telemetry Middleware', function () {
     ctx.services.telemetry = originalTelemetry
   })
 
-  it('should call next without gathering telemetry when state is unfulfillable', async () => {
-    ctx.state.unfulfillable = true
+  it('should call next without gathering telemetry when outgoing payment is not yet completed (checked by the existance of response.fulfill)', async () => {
+    ctx.response.fulfill = undefined
 
     const collectAmountSpy = jest.spyOn(telemetry, 'collectTelemetryAmount')