Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing annotation on Contacts property in ContactList #129

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

lkabell
Copy link

@lkabell lkabell commented Feb 19, 2020

Why?

The Contacts list would always be empty because of the missing JSON annotation on the Contacts field, e.g. when doing

contactList, err := ic.Contacts.List(intercom.PageParams{Page: 2})
contactList.Contacts

contactList.Contacts would be empty.

How?

Added JSON annotation.

@lkabell lkabell changed the title Add missing annotation on contact property in ContactList Add missing annotation on Contacts property in ContactList Feb 19, 2020
@taipeicoder
Copy link

Same goes for other resources (e.g: CompanyList)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants