Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed /bin/sh and robustified entrypoint/command translation k8s #34

Merged

Conversation

antoinetran
Copy link
Contributor

@antoinetran antoinetran commented Oct 29, 2024

Summary

Fixes #32

Related issue :

@antoinetran
Copy link
Contributor Author

@dciangot I don't have the power to assign, so I am pinging you

@antoinetran
Copy link
Contributor Author

@dciangot the pull request is already ready for review and merge

Copy link
Collaborator

@dciangot dciangot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the removal of hacky bash script.
Looks much cleaner now.

LGTM

@dciangot dciangot merged commit 1bea02e into interTwin-eu:main Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ENTRYPOINT support
2 participants