OpenTelemetry tracing for the interLink API server #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Surax98 <[email protected]>
Surax98
force-pushed
the
otel_interlink
branch
from
5564843
to
ac9a4b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following the #272 PR, this one aims to implement a Otel tracing for the API server.
Since a function to set some spans' attributes was common, it has been moved to a new file called spans.go which is part of the interlink package, so any other applicative (for example plugins) can use it to set the duration of a monitored part of the code. This function supports Functional Options, so it can be easily expanded with more functionalities in the future. Right now, it supports WithHTTPReturnCode(code) as option, setting this HTTP status code as an attribute of the span; in the same way, more options will be possible to be passed to set more attributes using the same function.
Related issue :