Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort the list and remove duplicate op #834

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

sort the list and remove duplicate op #834

wants to merge 1 commit into from

Conversation

yuchengliu1
Copy link
Contributor

@yuchengliu1 yuchengliu1 commented Aug 28, 2024

OPS in xpu_functions.yaml but not in _xpu_computation_op_list:

"complex.out",
"zero_",
"rsub",
"random",
"nn.functional.dropout",
"to_copy",
"set_",
"_copy_from_and_resize",
"_copy_from",
"nn.functional.layer_norm",
"index",
"max",
"min",
"mean",
"argmax",
"_local_scalar_dense",# or scalar_tensor
"col2im",
"batch_norm_stats",
"batch_norm_elemt",
"batch_norm_update_stats",
"batch_norm_backward",
"upsample_bicubic2d",
"upsample_bilinear2d_backward",
"_embedding_bag",
"is_set_to",
"reflection_pad1d",# and its variants
"replication_pad1d",# and its variants
"_amp_foreach_non_finite_check_and_unscale_",
"_amp_update_scale_",
"ceil",
"upsample_linear1d",
"_weight_norm_interface",
"range",
"_efficientzerotensor",
"_index_put_impl_",

OPS in _xpu_computation_op_list but not in xpu_functions.yaml:

"zeros",
"zeros_like",
"copy",
"index_put",
"nn.functional.pad",
"reshape",
"nanmean",

@yuchengliu1 yuchengliu1 marked this pull request as draft August 28, 2024 03:28
@majing921201
Copy link
Contributor

Which is duplicate op we removed in this pr ?

@yuchengliu1
Copy link
Contributor Author

Which is duplicate op we removed in this pr ?

Although this PR removed duplicate ops by sort it, this PR not focus on duplicate ops. Do you need the list of duplicate ops?

@majing921201
Copy link
Contributor

Which is duplicate op we removed in this pr ?

Although this PR removed duplicate ops by sort it, this PR not focus on duplicate ops. Do you need the list of duplicate ops?

thanks, no need the list, I am just curious, because I didn't find duplicate op, maybe I missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants