ensure PcmMsrClient can only opened by root

intel · Nov 16, 2023 · cf555cd · cf555cd
1 parent dd02c99
commit cf555cd
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/MacMSRDriver/PcmMsr/PcmMsrClient.cpp b/src/MacMSRDriver/PcmMsr/PcmMsrClient.cpp
@@ -41,10 +41,23 @@ IOReturn PcmMsrClientClassName::externalMethod(uint32_t selector, IOExternalMeth
 	return super::externalMethod(selector, args, dispatch, target, reference);
 }
 
+bool PcmMsrClientClassName::initWithTask(task_t owningTask, void *securityToken, UInt32 type, OSDictionary *properties)
+{
+    if(!IOUserClient::initWithTask(owningTask, securityToken, type, properties)) {
+        return false;
+    }
+
+    sSecurityToken = securityToken;
+    return true;
+}
+
 bool PcmMsrClientClassName::start(IOService* provider)
 {
 	bool result = false;
-
+
+    if(clientHasPrivilege(sSecurityToken, kIOClientPrivilegeAdministrator) != kIOReturnSuccess) 
+		return false;
+
     fProvider = OSDynamicCast(PcmMsrDriverClassName, provider);
 
     if (fProvider != NULL) {

diff --git a/src/MacMSRDriver/PcmMsr/PcmMsrClient.h b/src/MacMSRDriver/PcmMsr/PcmMsrClient.h
@@ -14,11 +14,13 @@ class PcmMsrClientClassName : public IOUserClient
 
 protected:
     PcmMsrDriverClassName*                  fProvider;
+    void*                                   sSecurityToken;
     static const IOExternalMethodDispatch   sMethods[kNumberOfMethods];
 
 public:
+    virtual bool initWithTask(task_t owningTask, void *securityToken, UInt32 type, OSDictionary *properties) override;
     virtual bool start(IOService *provider) override;
-
+    
     virtual IOReturn clientClose(void) override;
 
     virtual bool didTerminate(IOService* provider, IOOptionBits opts, bool* defer) override;