Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Reenable fp64 aspect runtime check #8682

Merged
merged 2 commits into from
Mar 23, 2023
Merged

[SYCL] Reenable fp64 aspect runtime check #8682

merged 2 commits into from
Mar 23, 2023

Conversation

steffenlarsen
Copy link
Contributor

This commit reenables the fp64 aspect check when ensuring compatibility of a given device image, following the relaxation of aspect propagation for the aspect.

@steffenlarsen steffenlarsen requested a review from a team March 16, 2023 17:20
@steffenlarsen
Copy link
Contributor Author

This is currently based on #8681. e892f1f are the relevant changes, but they depend on the aforementioned PR. This is opened as draft for the sake of testing.

@steffenlarsen
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1668

@steffenlarsen steffenlarsen temporarily deployed to aws March 16, 2023 18:23 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 16, 2023 19:37 — with GitHub Actions Inactive
@steffenlarsen
[SYCL] Reenable fp64 aspect runtime check
92f7701 
This commit reenables the fp64 aspect check when ensuring compatability
of a given device image, following the relaxation of aspect propagation
for the aspect.

Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen steffenlarsen force-pushed the steffen/relax_fp64_check.cpp branch from e892f1f to 92f7701 Compare March 22, 2023 12:17
@steffenlarsen
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1668

@steffenlarsen steffenlarsen marked this pull request as ready for review March 22, 2023 12:43
@steffenlarsen steffenlarsen requested a review from a team as a code owner March 22, 2023 12:43
@steffenlarsen
Copy link
Contributor Author

#8681 was merged, so this is ready for review.

@steffenlarsen steffenlarsen temporarily deployed to aws March 22, 2023 13:23 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 22, 2023 14:24 — with GitHub Actions Inactive
@steffenlarsen
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1668

@steffenlarsen
Copy link
Contributor Author

/verify with intel/llvm-test-suite#1668

@steffenlarsen steffenlarsen temporarily deployed to aws March 22, 2023 20:00 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen temporarily deployed to aws March 22, 2023 20:47 — with GitHub Actions Inactive
@steffenlarsen steffenlarsen mentioned this pull request Mar 23, 2023
Closed
@steffenlarsen
Copy link
Contributor Author

Windows Failed Tests (1):
SYCL :: Plugin/level_zero_imm_cmdlist_per_thread.cpp
Reported in #8753.

@steffenlarsen steffenlarsen merged commit 7663dc2 into intel:sycl Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-semenov sergey-semenov sergey-semenov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steffenlarsen @sergey-semenov