-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add VAProfileH264High10 #664
Conversation
c027ff4
to
95ced16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we dont need the VA_PROFILE_H264_HIGH_10, please remove it, driver could determine whether report such profile.
and , is it convenient to share which driver will support high 10 profile, enc or dec?
bb0d700
to
5957742
Compare
Do we have an idea which drivers will support this profile - any of the Intel ones (i965, iHD), mesa (radeonsi, nouveau) or some other? More importantly - I think we need to update the tests, right? |
I'm now working for Moore Threads. Moore Threads (short for Mthreads) is a Chinese GPU manufacturer. Our newest products, MTTS80/MTTS2000/MTT3000, all has H264High10 enc/dec capabilities at max 8k resolution. Beside H264High10, our produncts also support AVS+ and AVS2 video decoding that are now all out of VAAPI definition. And we also wish to add them to VAAPI.
For H264High10, since only enum VAProfileHigh10 has been added, I think it may not need to test for LIBVA. Rather, MediaDriver and uplayer application like gstreamer or FFMpeg need to be test. We actually has bring up both decoding and encoding wok flow under FFmpeg and test under vaapi-fits. |
The test suite in libva-utils will also need small changes. See my comment in intel/libva-utils#274 for some pointers. Adding ffmpeg and vaapi-fits support sounds amazing, thank you \o/ |
hi evelikov, intel/libva-utils#298 has been created. |
see [intel/libva#664](intel/libva#664) Signed-off-by: jianfeng.zheng <[email protected]>
see intel/libva#664 Signed-off-by: jianfeng.zheng <[email protected]>
b13d14b
to
940820b
Compare
see intel/libva#664 Signed-off-by: jianfeng.zheng <[email protected]>
see intel/libva#664 Signed-off-by: jianfeng.zheng <[email protected]>
see intel/libva#664 Signed-off-by: jianfeng.zheng <[email protected]>
Hi their,
Corresponding ffmpeg patch has been send to ffmpeg-devel mail list, see
http://ffmpeg.org/pipermail/ffmpeg-devel/2022-December/305100.html
or
FFmpeg/FFmpeg@master...gitgjogh:FFmpeg:VAProfileH264High10
Thanks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks
Signed-off-by: jianfeng.zheng <[email protected]>
940820b
to
2b64636
Compare
rebased
XinfengZhang ***@***.***> 于2023年1月5日周四 10:23写道:
… ***@***.**** approved this pull request.
LGTM now, thanks
—
Reply to this email directly, view it on GitHub
<#664 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJERSDBCP4KRSSWMROMSALWQYWARANCNFSM6AAAAAAS6GB2AA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
see intel/libva#664 Signed-off-by: jianfeng.zheng <[email protected]>
see intel/libva#664 Signed-off-by: jianfeng.zheng <[email protected]>
see intel/libva#664 Signed-off-by: jianfeng.zheng <[email protected]>
see intel/libva#664 Signed-off-by: jianfeng.zheng <[email protected]>
see intel/libva#664 Signed-off-by: jianfeng.zheng <[email protected]>
see intel/libva#664 Signed-off-by: jianfeng.zheng <[email protected]>
see intel/libva#664 Signed-off-by: jianfeng.zheng <[email protected]>
see intel/libva#664 Signed-off-by: jianfeng.zheng <[email protected]>
see intel/libva#664 Signed-off-by: jianfeng.zheng <[email protected]>
see intel/libva#664 Signed-off-by: jianfeng.zheng <[email protected]>
see intel/libva#664 Signed-off-by: jianfeng.zheng <[email protected]>
see intel/libva#664 Signed-off-by: jianfeng.zheng <[email protected]>
see intel/libva#664 Signed-off-by: jianfeng.zheng <[email protected]>
Signed-off-by: jianfeng.zheng [email protected]