-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to bringup host IDPF netdevices #221
Change to bringup host IDPF netdevices #221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment. LGTM
fe108d0
to
f05dd35
Compare
will do rmmod/modprobe to bring up those those net devices.
75db25f
to
7057734
Compare
@@ -539,6 +578,8 @@ func (s *LifeCycleServiceServer) Init(ctx context.Context, in *pb.InitRequest) ( | |||
} | |||
} | |||
|
|||
checkIdpfNetDevices(s.mode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add error condition in checkIdpfNetDevices has zero pfList after rmmod/insmod to bringup idpf interfaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vkannapp Hi Vadivel, you mean...after rmmod/insmod...if pflist is 0, to throw an error message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right! Error condition if IPU/idpf interfaces doesn't come up.
* Change to bringup host IDPF netdevices (#221) When VSP gets started, if host IDPF net devices are not there, VSP will do rmmod/modprobe to bring up those those net devices. * This PR is a follow-up to SetNumVFs proto file change in DPU-> (#223) openshift/dpu-operator#124 Support for SetNumVfs added to DevicePluginService. As part of this PR, we look for Intel IPU PCI device(1452), on the host system, and set the sriov_numvfs for it. VSP(intel plugin) returns the numvfs set back to caller(DPU). Added polling to check thro cli-client query if VF net devices have been created. * Changes for removing args passed in vsp-ds.yaml. (#224) We can still pass args(for debugging purpose). But for now, except for log level, rest have been removed. Also code to find vsi for bridge interface(on ACC side) has been added. * Randomize last 2 bytes(5th and 6th) of MAC address in node policy. (#225)
* P4 artefacts commit for 1.6.2 migration (#222) * P4 artefacts commit for 1.6.2 migration. * P4 artefacts commit for 1.6.2 migration * Adding the linux bridge setup commands * Correcting the bridge command in linux_brige_setup * Merge changes from main to 1.6.2 branch (#226) * Change to bringup host IDPF netdevices (#221) When VSP gets started, if host IDPF net devices are not there, VSP will do rmmod/modprobe to bring up those those net devices. * This PR is a follow-up to SetNumVFs proto file change in DPU-> (#223) openshift/dpu-operator#124 Support for SetNumVfs added to DevicePluginService. As part of this PR, we look for Intel IPU PCI device(1452), on the host system, and set the sriov_numvfs for it. VSP(intel plugin) returns the numvfs set back to caller(DPU). Added polling to check thro cli-client query if VF net devices have been created. * Changes for removing args passed in vsp-ds.yaml. (#224) We can still pass args(for debugging purpose). But for now, except for log level, rest have been removed. Also code to find vsi for bridge interface(on ACC side) has been added. * Randomize last 2 bytes(5th and 6th) of MAC address in node policy. (#225) * Change in intel plugin, to turn off learning for outer vlan. Change was tested independently(not with DPU). * Changes to ensure p4sdk container comes up with 1.6+ (#227) Signed-off-by: Sayan Bandyopadhyay <[email protected]> * New artifacts for rh_mvp Signed-off-by: Sayan Bandyopadhyay <[email protected]> --------- Signed-off-by: Sayan Bandyopadhyay <[email protected]> Co-authored-by: mchelliyil <[email protected]> Co-authored-by: sudhar-krishnakumar <[email protected]>
When VSP gets started, if host IDPF net devices are not there, VSP
will do rmmod/modprobe to bring up those those net devices.