Change to bringup host IDPF netdevices #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudhar-krishnakumar
force-pushed
the
sk_changes
branch
from
fe108d0
to
f05dd35
Compare
will do rmmod/modprobe to bring up those those net devices.
sudhar-krishnakumar
force-pushed
the
sk_changes
branch
2 times, most recently
from
75db25f
to
7057734
Compare
vkannapp
reviewed
Aug 23, 2024
| @@ -539,6 +578,8 @@ func (s *LifeCycleServiceServer) Init(ctx context.Context, in *pb.InitRequest) ( | |||
| } | |||
| } | |||
|
|
|||
| checkIdpfNetDevices(s.mode) | |||
There was a problem hiding this comment.
Add error condition in checkIdpfNetDevices has zero pfList after rmmod/insmod to bringup idpf interfaces.
There was a problem hiding this comment.
@vkannapp Hi Vadivel, you mean...after rmmod/insmod...if pflist is 0, to throw an error message.
There was a problem hiding this comment.
Right! Error condition if IPU/idpf interfaces doesn't come up.
sudhar-krishnakumar
added a commit
that referenced
this pull request
Sep 19, 2024
* Change to bringup host IDPF netdevices (#221) When VSP gets started, if host IDPF net devices are not there, VSP will do rmmod/modprobe to bring up those those net devices. * This PR is a follow-up to SetNumVFs proto file change in DPU-> (#223) openshift/dpu-operator#124 Support for SetNumVfs added to DevicePluginService. As part of this PR, we look for Intel IPU PCI device(1452), on the host system, and set the sriov_numvfs for it. VSP(intel plugin) returns the numvfs set back to caller(DPU). Added polling to check thro cli-client query if VF net devices have been created. * Changes for removing args passed in vsp-ds.yaml. (#224) We can still pass args(for debugging purpose). But for now, except for log level, rest have been removed. Also code to find vsi for bridge interface(on ACC side) has been added. * Randomize last 2 bytes(5th and 6th) of MAC address in node policy. (#225)
saynb
added a commit
that referenced
this pull request
Oct 14, 2024
* P4 artefacts commit for 1.6.2 migration (#222) * P4 artefacts commit for 1.6.2 migration. * P4 artefacts commit for 1.6.2 migration * Adding the linux bridge setup commands * Correcting the bridge command in linux_brige_setup * Merge changes from main to 1.6.2 branch (#226) * Change to bringup host IDPF netdevices (#221) When VSP gets started, if host IDPF net devices are not there, VSP will do rmmod/modprobe to bring up those those net devices. * This PR is a follow-up to SetNumVFs proto file change in DPU-> (#223) openshift/dpu-operator#124 Support for SetNumVfs added to DevicePluginService. As part of this PR, we look for Intel IPU PCI device(1452), on the host system, and set the sriov_numvfs for it. VSP(intel plugin) returns the numvfs set back to caller(DPU). Added polling to check thro cli-client query if VF net devices have been created. * Changes for removing args passed in vsp-ds.yaml. (#224) We can still pass args(for debugging purpose). But for now, except for log level, rest have been removed. Also code to find vsi for bridge interface(on ACC side) has been added. * Randomize last 2 bytes(5th and 6th) of MAC address in node policy. (#225) * Change in intel plugin, to turn off learning for outer vlan. Change was tested independently(not with DPU). * Changes to ensure p4sdk container comes up with 1.6+ (#227) Signed-off-by: Sayan Bandyopadhyay <[email protected]> * New artifacts for rh_mvp Signed-off-by: Sayan Bandyopadhyay <[email protected]> --------- Signed-off-by: Sayan Bandyopadhyay <[email protected]> Co-authored-by: mchelliyil <[email protected]> Co-authored-by: sudhar-krishnakumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When VSP gets started, if host IDPF net devices are not there, VSP
will do rmmod/modprobe to bring up those those net devices.