Change to use internal interface->enp0s1f0d4(d4), on ACC, for host<->ACC communication #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, tested and verified pod-2-pod is working with these updates / vsp is able to communicate from host to card. |
vkannapp
reviewed
Aug 15, 2024
| return status.Error(codes.Internal, err.Error()) | ||
| } | ||
|
|
||
| pf, err := getCommPf(mode, pfList) | ||
|
|
||
| if pf == nil { | ||
| // Address already set - we don't proceed with setting the ip | ||
| fmt.Printf("configureChannel: pf nil from getCommPf") |
There was a problem hiding this comment.
Can we add the log level to the additional printf traces or is it intended to show up as part of configure channel?
There was a problem hiding this comment.
ok, I have removed one of the debug print, the rest are for mostly for error cases.
vkannapp
approved these changes
Aug 15, 2024
for host<->ACC communication. Previously d2 interface was used on ACC, which was meant for external network interface. Using external interface D2 also caused issue when fixed(unique) MAC was set thro fixboard script, since VSP checks for vportid in MAC. Since above change would reduce the number of APFs returned by GetDevices by 1, value of ->acc_apf in node-policy has been increased to 16.
sudhar-krishnakumar
force-pushed
the
sk_fixmac
branch
from
3041a6f
to
02720ff
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to use internal interface->enp0s1f0d4(d4), on ACC, for host<->ACC communication. Previously d2 interface was used on ACC, which was meant for external network interface. Using external interface D2 also caused issue when fixed(unique) MAC was set thro fixboard script, since VSP checks for vportid in MAC. Since above change would reduce the number of APFs returned by GetDevices by 1, value of ->acc_apf in node-policy has been increased to 16.