Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mako dependency #317

Closed
wants to merge 1 commit into from
Closed

Add mako dependency #317

wants to merge 1 commit into from

Conversation

chsasank
Copy link
Contributor

Without this, the build fails with following error:

Consolidate compiler generated dependencies of target obj.clangFormat                                                                                                                                              
Consolidate compiler generated dependencies of target obj.clangToolingInclusions                                                                                                                                   
Traceback (most recent call last):                                                                                                                                                                                 
  File "/home/sasank/code/igc_workspace/igc/IGC/GenISAIntrinsics/generator/generate_intrinsic_files.py", line 11, in <module>                                                                                      
    from Intrinsic_utils import file_path, dir_path                                                                                                                                                                
  File "/home/sasank/code/igc_workspace/igc/IGC/GenISAIntrinsics/generator/Intrinsic_utils.py", line 14, in <module>                                                                                               
    from mako.template import Template                                                                                                                                                                             
ModuleNotFoundError: No module named 'mako'                                                                                                                                                                        
Consolidate compiler generated dependencies of target obj.clangToolingCore                                                                                                                                         
Consolidate compiler generated dependencies of target obj.clangRewrite
Consolidate compiler generated dependencies of target obj.clangCrossTU
make[2]: *** [IGC/GenISAIntrinsics/CMakeFiles/GenISAIntrinsics.dir/build.make:84: IGC/Release/GenIntrinsicDescription.h] Error 1
make[1]: *** [CMakeFiles/Makefile2:33415: IGC/GenISAIntrinsics/CMakeFiles/GenISAIntrinsics.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

So added instructions to install mako into docs.

@pszymich
Copy link
Contributor

pszymich commented May 9, 2024

Hi, we process the PRs internally and a recent documentation commit has integrated some or all of your suggestions. You've been added as a coauthor. f13266a
Thanks!

@pszymich pszymich closed this May 9, 2024
@eero-t
Copy link

eero-t commented May 10, 2024

@pszymich Why docs now state that user should install mako with pip:
https://github.com/intel/intel-graphics-compiler/blob/master/documentation/build_ubuntu.md

When e.g. IGC's own build script for Ubuntu uses python3-mako distro package for it:
https://github.com/intel/intel-graphics-compiler/blob/master/scripts/buildIGC.sh#L52
?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants