This repository has been archived by the owner on Oct 25, 2024. It is now read-only.
Bump neural docker base #1633
Open
Bump neural docker base #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashahba
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Thanks @Chris-Sigopt for this PR.
However I'm not sure if other Dockerfiles in the repo also need similar update.
Thanks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Bug Fix
API Unchanged
Description
Working with customer on a 1.15.0 IDC machine, and he could not get neural_chat_server to run because the base of the image was 1.13.0, not 1.15.0, and transformers was version-locked to a version that worked for 1.13.0.
Expected Behavior & Potential Risk
We expect the neural_chat Dockerfile to run on a 1.15.0 IDC machine so customers can actually run this without having to debug Dockerfile themselves.
Potential risk is that this will still be 1.15.0, not 1.16.0 when that is ready for IDC.
How has this PR been tested?
By running on 1.15.0 IDC machine.
Dependency Change?
Change version of Transformers library to be the correct version that runs.