Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPU plugin README prerequisites section #1149

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Conversation

eero-t
Copy link
Contributor

@eero-t eero-t commented Sep 9, 2022

This was inspired by ticket #1109, and fills one of the items listed in ticket #1060, by documenting how to get suitable kernel and user-space drivers. It also slightly updates other related sections.

Note: Kernel driver installation section is quite large because currently there does not seem to be any official documentation on how to install Intel discrete GPU kernel drivers. When there is, that section needs rewrite.

For now, I put installation of both kernel driver (= cluster admin responsibility), and user-space drivers (= WL developer responsibility) under prerequisites section, although it could be argued that latter could belong also to a (currently missing) "GPU plugin usage" section [1].

PS. I looked into splitting prerequisites and usage parts out of the fractionalization install section, but gave up. I think @uniemimu or @tkatila are the the only ones who can do that. After those are split out, there's actually some meat for the "GPU plugin usage" section.

[1] ticket #1045 asks for role-based documentation split-up.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022

Codecov Report

Merging #1149 (b9d1c43) into main (63481a2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1149   +/-   ##
=======================================
  Coverage   52.99%   52.99%           
=======================================
  Files          40       40           
  Lines        4374     4374           
=======================================
  Hits         2318     2318           
  Misses       1927     1927           
  Partials      129      129           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eero-t
Copy link
Contributor Author

eero-t commented Sep 19, 2022

Rebased to "main" to resolve conflicts with recently merged documentation changes.

cmd/gpu_plugin/README.md Outdated Show resolved Hide resolved
cmd/gpu_plugin/README.md Outdated Show resolved Hide resolved
tkatila
tkatila previously approved these changes Sep 20, 2022
@eero-t eero-t changed the title WIP: Add GPU plugin README prerequisites section Add GPU plugin README prerequisites section Sep 23, 2022
@eero-t
Copy link
Contributor Author

eero-t commented Sep 23, 2022

Better to merge this as is, and add information about DKMS when it actually becomes available. I made the GPU info in example outputs consistent, and squashed all changes to a single commit.

Copy link
Member

@bart0sh bart0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bart0sh bart0sh merged commit 89d3c5a into intel:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants