This repository has been archived by the owner on Aug 5, 2022. It is now read-only.
Make WebClient examples consistent #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the DNS name for google by default in the Ethernet WebClient sketch, and leave the numeric IP commented out, like in the WiFiWebClient example.
|
@calvinatintel don't merge yet, Noel to review & test. |
|
Works on a Galileo Gen2 over wired Ethernet. The original IP address seems to be invalid now though. |
|
@bbaltz505 thanks, yes they do change every now and then. A previous change added the line |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the DNS name for google by default in the
Ethernet WebClient sketch, and leave the numeric
IP commented out, like in the WiFiWebClient
example.