✨ Introduce log environment #679
Open
+232
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - `stdx` added a breaking change, viz. the ct_string format result always being returned from `ct_format`. Solution: - Update code to deal with that.
elbeno
force-pushed
the
log-env
branch
2 times, most recently
from
0d5762e to
c887b00
Compare
Problem: - Logging is parameterized on many axes. Most logging systems include the level. Some also include a module or source. Some include other parameters. - Logging machinery should be agnostic to the parameterizations of each logging backend. Adding extra parameters to logging macros is not scalable. Solution: - Expand the current logging module to the idea of a logging environment. An environment allows compile-time scope-based arguments to be passed through the logging machinery; logging backends can extract whichever values they can use from the current environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Some also include a module or source. Some include other parameters.
backend. Adding extra parameters to logging macros is not scalable.
Solution:
environment allows compile-time scope-based arguments to be passed through the
logging machinery; logging backends can extract whichever values they can use
from the current environment.