Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add check for module ID limit #677

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ Add check for module ID limit #677

wants to merge 1 commit into from

Conversation

elbeno
Copy link
Contributor

@elbeno elbeno commented Jan 11, 2025

Problem:

  • The MIPI-SyST spec allows 7 bits for the module ID field. A codebase could accidentally exceed this limit, leading to unpredictable effects.

Solution:

  • Check the max value of a module is not exceeded.
  • Allow the max value to be customized so that alternative backends can provide alternative limits.

@elbeno
✨ Add check for module ID limit
7808e69 
Problem:
- The MIPI-SyST spec allows 7 bits for the module ID field. A codebase could
  accidentally exceed this limit, leading to unpredictable effects.

Solution:
- Check the max value of a module is not exceeded.
- Allow the max value to be customized so that alternative backends can provide
  alternative limits.
@elbeno elbeno marked this pull request as ready for review January 11, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukevalenty lukevalenty Awaiting requested review from lukevalenty

@mjcaisse-intel mjcaisse-intel Awaiting requested review from mjcaisse-intel

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@elbeno