Return 422 if event processing failes #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltesa
force-pushed
the
failure-response-codes
branch
from
981adc2 to
93f3a31
Compare
dmz006
added a commit
to dmz006/stripe_event
that referenced
this pull request
Jan 18, 2021
…lis#132 commit 93f3a31 Signed-off-by: David M. Zendzian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a
StripeEvent::ProcessError. If catched in theWebhookControllera 422 StatusCode is returned. I think it breaks the processing of the event by other subscribers, so it is not a good solution to the issue it tries to solve: #131