Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iPad 18 NavigationBar appearance issue on swipe-to-back gesture #3094

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

suhaibabsi-inst
Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst commented Jan 29, 2025

refs: MBL-18165
affects: Student, Teacher
release note: Fix the iPad 18 layout issue of dashboard navigation bar.

Test Plan

See ticket's description.

Screen Recording

ipad_issue_solved.mov

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

refs: MBL-18165
affects: Student, Teacher
release note: Fix the iPad 18 layout issue of dashboard navigation bar.
@inst-danger
Copy link
Contributor

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Jan 29, 2025

Fails
🚫 Build failed, skipping coverage check

Release Note:

Fix the iPad 18 layout issue of dashboard navigation bar.

Affected Apps: Student, Teacher

MBL-18165

❌ XCTest failed: CoreTests/WKHTTPCookieStoreExtensionsTests/testDeleteAllCookies
Asynchronous wait failed: Exceeded timeout of 0.1 seconds, with unfulfilled expectations: "Publisher finished".
XCTAssertEqual failed: ("[<NSHTTPCookie
	version:1
	name:testName
	value:testValue
	expiresDate:'(null)'
	created:'2025-01-29 11:01:50 +0000'
	sessionOnly:TRUE
	domain:instructure.com
	partition:none
	sameSite:none
	path:/login
	isSecure:FALSE
 path:"/login" isSecure:FALSE>]") is not equal to ("[]")

Generated by 🚫 dangerJS against 69297cf

@suhaibabsi-inst suhaibabsi-inst marked this pull request as ready for review January 29, 2025 11:13
@suhaibabsi-inst suhaibabsi-inst self-assigned this Jan 29, 2025
Copy link
Contributor

@ndrsszsz ndrsszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants