Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Back toolbar button to QuizLTI webview #3093

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

rh12
Copy link
Contributor

@rh12 rh12 commented Jan 29, 2025

refs: MBL-18184
affects: Student, Teacher, Parent
release note: none

QuizLTI back button at the bottom toolbar is now visible when the webview is navigated forward (which means there is someting to go back to)

Test plan

  • Verify back button appears when QuizLTI webview navigates to another screen and disappears when tapping back.
  • Smoke test back navigation works from Module to Dashboard.

Screenshots TODO

BeforeAfter

Checklist

  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode

refs: MBL-18184
affects: Student, Teacher, Parent
release note: none
@inst-danger
Copy link
Contributor

Parent Build QR Code:

@inst-danger
Copy link
Contributor

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

Student Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Jan 29, 2025

Warnings
⚠️ This pull request will not generate a release note.
⚠️ One or more files are below the minimum test coverage 50%

Affected Apps: Student, Teacher, Parent

MBL-18184

Coverage New % Master % Delta
Canvas iOS 91.35% 91.35% 0%
Core/Core/Common/CommonModels/Store/FetchedCollection.swift 48.72% 48.72% 0%
Core/Core/Common/Extensions/Foundation/CGSizeExtensions.swift 0% 0% 0%
Core/Core/Features/Courses/SmartSearch/Model/CourseSmartSearchViewAttributes.swift 30.77% 30.77% 0%
Core/Core/Common/Extensions/SwiftUI/UIColor+Color.swift 0% 0% 0%
Core/Core/Features/Search/Model/SearchSupportButtonModel.swift 0% 0% 0%
Core/Core/Common/CommonModels/AppEnvironment/AppEnvironmentOverride.swift 32.76% 32.76% 0%

Generated by 🚫 dangerJS against 9d92081

Copy link
Collaborator

@vargaat vargaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA+1, thanks for the refactor!

@suhaibabsi-inst
Copy link
Contributor

QA +1
Tested on iOS 18.2.1, Student App.

@rh12 rh12 merged commit 0556598 into master Jan 29, 2025
6 checks passed
@rh12 rh12 deleted the feature/MBL-18184-New-Quiz-Dedicated-WebView-followups branch January 29, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants