Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Respect User selected locale in Calendar calculation #3041

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

suhaibabsi-inst
Copy link
Contributor

This is to respect the default Calendar's "firstOfWeek" property of the locale selected by user on desktop web app.

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

@inst-danger
Copy link
Contributor

inst-danger commented Dec 22, 2024

Warnings
⚠️ One or more files are below the minimum test coverage 50%
Coverage New % Master % Delta
Canvas iOS 91.27% 91.27% -0.01%
Core/Core/Common/CommonModels/Store/FetchedCollection.swift 48.72% 48.72% 0%
Core/Core/Common/Extensions/Foundation/CGSizeExtensions.swift 0% 0% 0%
Core/Core/Features/Courses/SmartSearch/Model/CourseSmartSearchViewAttributes.swift 30.77% 30.77% 0%
Core/Core/Common/Extensions/SwiftUI/UIColor+Color.swift 0% 0% 0%
Core/Core/Features/Search/Model/SearchSupportButtonModel.swift 0% 0% 0%
Core/Core/Common/CommonModels/AppEnvironment/AppEnvironmentOverride.swift 32.76% 32.76% 0%

Generated by 🚫 dangerJS against 01b0911

@suhaibabsi-inst suhaibabsi-inst self-assigned this Dec 22, 2024
@inst-danger
Copy link
Contributor

Builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants