fixed react warnings #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixed React PropTypes warning * fixed React creatClass warning
janstuemmel
pushed a commit
to janstuemmel/react-mce
that referenced
this pull request
Jun 13, 2017
* added karma/mocha testsuite * deleted old test related to instructure-react#65
janstuemmel
force-pushed
the
upgrade-react
branch
from
6b27ab0
to
3e90edd
Compare
added 2 commits
June 14, 2017 02:46
* added gulp build and example buid * edited readme * edited package.json for npm release
|
I forked the repo, added some tests and published it on npm at react-mce |
|
Thank you for this! Any idea when it will make it into master? edit last commits a year ago...doesn't seem likely 😢 |
|
it won't. my fork implements some useful testcases, but a few more are welcome. indeed my PR is not ment to be merged, because there to many changes and commits |
|
@mzabriskie dude, can you look at this? seems to work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related with #60 #61