Using Confluence documents as a knowledge source #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makelinux
changed the title
bjhargrave
requested changes
May 28, 2024
docs/confluence-doc-source.md
Outdated
| - [ilab utilities module](https://github.com/instructlab/instructlab/blob/main/src/instructlab/utils.py) | ||
| fetches documents | ||
| - [unit test](https://github.com/instructlab/instructlab/tree/main/tests) | ||
|
|
There was a problem hiding this comment.
In order to support the schema change, ilab, the taxonomy repo (possibly private) and the backend implementation (which does the proper SDG and training from the taxonomy repo) all must agree on the schema so they have a shared understanding of what a qna.yaml file looks like. So it requires coordination between ilab, the backend implementation and the taxonomy repo(s). So making a change in ilab alone is not sufficient.
So this design change will also require support/approval from the backend (SDG) team.
bjhargrave
changed the title
|
@makelinux could you please address @bjhargrave's comments so we can move forward? Thanks! |
hickeyma
requested changes
Jul 3, 2024
makelinux
force-pushed
the
confluence
branch
3 times, most recently
from
d37ada8
to
3d955b6
Compare
Signed-off-by: Costa Shulyupin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview:
Confluence document source